Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kube-prometheus] Enable PodDisruptionBudgets (part 2) #26700

Merged
merged 6 commits into from
Jun 6, 2024

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented Jun 4, 2024

Description of the change

Enabled PodDisruptionBudget by default. In previous #26553 PR, PDBs were not enabled by default.

Benefits

PDB protects our applications from voluntary disruption initiated by cluster administrators.
Keep our charts up to date according to our templates.

Possible drawbacks

None

Aditional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@fmulero fmulero enabled auto-merge (squash) June 4, 2024 12:43
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 4, 2024
@github-actions github-actions bot requested a review from rafariossaa June 4, 2024 12:43
Signed-off-by: Bitnami Containers <[email protected]>
@fmulero fmulero changed the title [bitnami/kube-prometheus] Enable PodDisruptionBudgets [bitnami/kube-prometheus] Enable PodDisruptionBudgets (part 2) Jun 5, 2024
fmulero and others added 4 commits June 5, 2024 08:48
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmulero fmulero merged commit 2b1b982 into bitnami:main Jun 6, 2024
9 checks passed
@github-actions github-actions bot added the solved label Jun 6, 2024
@fmulero fmulero added the pdb label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami kube-prometheus pdb solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants